Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tiup: tiup: add more fields and links from customized-montior-in-tiup-environment.md #15851

Merged
merged 15 commits into from
Jan 22, 2024
Merged

tiup: tiup: add more fields and links from customized-montior-in-tiup-environment.md #15851

merged 15 commits into from
Jan 22, 2024
+11 −3

Conversation

hfxsd
Copy link
Collaborator

@hfxsd hfxsd commented Dec 22, 2023 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@hfxsd hfxsd self-assigned this Dec 22, 2023
@ti-chi-bot ti-chi-bot bot added the contribution This PR is from a community contributor. label Dec 22, 2023
@hfxsd hfxsd requested a review from Oreoxmt December 22, 2023 02:51
@ti-chi-bot ti-chi-bot bot added the missing-translation-status This PR does not have translation status info. label Dec 22, 2023
@hfxsd hfxsd requested a review from qqqdan December 22, 2023 02:51
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 22, 2023
@hfxsd hfxsd added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. ONCALL Relates to documentation oncall. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. and removed missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 22, 2023
hfxsd
hfxsd commented Dec 22, 2023
View reviewed changes
mysql-schema.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 22, 2023
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 22, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 22, 2024

@qqqdan: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hfxsd hfxsd changed the title tiup: add a link to customized-montior-in-tiup-environment tiup: tiup: add more fields and links from customized-montior-in-tiup-environment.md Jan 22, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 22, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-22 09:19:22.799088196 +0000 UTC m=+779604.363385901: ☑️ agreed by Oreoxmt.

@hfxsd hfxsd added lgtm and removed contribution This PR is from a community contributor. labels Jan 22, 2024
@hfxsd
Copy link
Collaborator Author

hfxsd commented Jan 22, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 22, 2024
@ti-chi-bot ti-chi-bot bot merged commit ddf24dd into pingcap:master Jan 22, 2024
8 of 9 checks passed
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Jan 22, 2024
@hfxsd @ti-chi-bot
tiup: tiup: add more fields and links from customized-montior-in-tiup…
93601fe 
…-environment.md (pingcap#15851)
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 22, 2024
Merged
18 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #16212.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.6: #16213.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Jan 22, 2024
@hfxsd @ti-chi-bot
tiup: tiup: add more fields and links from customized-montior-in-tiup…
6bb3858 
…-environment.md (pingcap#15851)
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 22, 2024
Merged
18 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Jan 22, 2024
@ti-chi-bot
tiup: tiup: add more fields and links from customized-montior-in-tiup…
352b82b 
…-environment.md (#15851) (#16212)
ti-chi-bot bot pushed a commit that referenced this pull request Jan 22, 2024
@ti-chi-bot
tiup: tiup: add more fields and links from customized-montior-in-tiup…
f7473e2 
…-environment.md (#15851) (#16213)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@qqqdan qqqdan qqqdan approved these changes

Assignees

@hfxsd hfxsd

Labels
approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. ONCALL Relates to documentation oncall. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hfxsd @ti-chi-bot @qqqdan @Oreoxmt